markus-jehl

Results 45 comments of markus-jehl

I didn't see a way to rename while keeping the original name as well. However, there seems to be the potential for an elegant way to strip "_sptr" from all...

This was tested for the NeuroLF scanner geometry, and the function indeed returns the correct results: for seg=5 and axial_pos=5 it returns 5 and 10, and for seg=2 and axial_pos=14...

Kris: "The ray really shouldn’t change if we ask it to compute intersections with a larger FOV. That might be another bug on how we call parallelproj (although our code...

![image](https://user-images.githubusercontent.com/87262701/193082387-870d7ce5-f078-420c-be2c-858503a5ee51.png) The "squashing" of the sinograms was caused by a bug in the code that computes intersections with a cylinder.

This sounds sensible to me. People that read and write the same file in a multi-threaded context can be expected to be knowledgeable enough to deal with this risk.

Kris (https://github.com/UCL/STIR/pull/1074): "I suspect it isn't the image radius though. Could you check what parallelproj does if you give it a small radius? Instead I think we should check the...

I tested it, and parallelproj works as expected for smaller radii. I now also added handling of the return value of get_intersections_with_cylinder. The remaining things to be done are: 1....

Initially, I was thinking of doing it as part of this PR - but I agree it would be nice to get this merged in sooner rather than later!