Mark Thomas

Results 274 comments of Mark Thomas

Clarify whether javax.servlet.error.exception_type and javax.servlet.error.exception refer to a wrapped or unwrapped ServletException

I think the TCK is checking that the original exception was thrown without wrapping. Section 9.5 sets out which exceptions should be wrapped if the target of a RequestDispacther throws...

Clarify whether javax.servlet.error.exception_type and javax.servlet.error.exception refer to a wrapped or unwrapped ServletException

@janbartel Tx for the pointer. I'll take a closer look.

Clarify whether javax.servlet.error.exception_type and javax.servlet.error.exception refer to a wrapped or unwrapped ServletException

I've been digging through the history and I think the current behaviour on unwrapping is as intended. The following change was made in Tomcat 4 back when it was the...

What to do about userinfo in URLs?

+1 for closing

Standardize authentication modules in Servlet

I think recommended is the right choice here.

Standardize authentication modules in Servlet

The consensus is, effectively, 'won't fix' so closing.

Clarify handling of IOException inside [Read|Write]Listener methods

Assuming we go with the approach that the container does not rely on the application not swallowing the exception, I'd say the answers to your questions are: - yes, the...

Fix wording in context root mapping in section 12.2

Fixed via #497

Clarify behaviour after ServletOutputStream.setWriteListener

Tomcat uses the async approach if complete() is called while an async read/write is in progress. I recently gave this code an overhaul in Tomcat. The updated state diagram that...

Clarify my responsibilities when I use Threadlocal variables in my Servlet.

What about ThreadLocals which were the original trigger for this issue being created?