Mark Thomas

Results 274 comments of Mark Thomas

I'm fine with the zero-arg optimisation. If others want the more general caching solution it can still be implemented.

I'm planning on applying this manually to main and then back-porting. So far I've made the following changes: - refactored the inner test classes to align with the rest of...

Those were the only changes required. Fix applied to main, 11.0.1, 10.1.x and 9.0.x.

With the refactoring of the JAR contents to avoid duplication of classes, the issue described in #180 should no longer occur. Therefore, the fix is no longer required. `EndpointConfig` belongs...

There should be a 2.2.1-SNAPSHOT available for you to test at: https://jakarta.oss.sonatype.org/content/repositories/snapshots/jakarta/websocket/

#493 was effectively accepted so I believe you can skip the affected test. That should allow 6.0 and 6.1 implementations to be consistent. The 6.0 TCK is not under the...

I'd argue it is a duplicate of #493 - I'd rather any addition to the 6.0 exclusion list referenced the original issue.

The Servlet 6.1 spec has required RFC 6265 compliance since Servlet 5.0. RFC 6265 explicitly states (section 4.1.1) ``` max-age-av = "Max-Age=" non-zero-digit *DIGIT ``` It is neither reasonable nor...

@covener Those are the requirements for user agents (section 5) which are generally more relaxed than the requirements for servers (section 4).