Mark Walker

Results 274 comments of Mark Walker

> Thoughts? Yeah I think that makes sense, if it makes sense to you when you're using it, as you say 👍🏼

@bmispelon Bit of scope creep at the 11th hour here, but I've added a formats file to allow us to customise the datetime formats. With this, it'd be good to...

> I don't think adding custom formats works Oh boy. Here's my first 🤦🏼 moment on this project. I convinced myself last night I was looking at the right pages...

@bmispelon Ok thanks - I've added those in now.

> For reference, the test we're using to avoid forgetting migrations: > > ``` > from io import StringIO > > from django.core.management import call_command > from django.test import TestCase...

@shiyanshirani yeah translated blocks need doing as well

@joshyu thanks for raising. I've not heard about this so will have to have a look at it & we'll let you know.

Yeah making it an pip optional install is a good idea via `setup.py`. I'd argue that it is already optional, its just installed by default. You don't actually have to...

@fsbraun that class name change is something that seems questionable - is that likely to break things for people is my current thought. Though I've only had a quick glance...

@stefanw ah ok, that makes sense then! Thank you for explaining. I think it's fine to leave as it is in that case. 👍