Mark Walker

Results 221 comments of Mark Walker

@chrisclark I think this might need your input as I suspect this is something you'd decided on.

@jwestfall thank you for your contribution. Could you please add tests for this?

@eeriksp Just realised, this needs the `setup.py` updating to handle the optional dependencies added here. There's a good example here; https://github.com/anymail/django-anymail/blob/main/setup.py#L62 At the moment we've got; ``` extras_require={ "xls": [...

@sdether Thanks for raising. Could you link to the relevant parts of the code please? Makes it a little easier for anyone reading the issue to see what you're referring...

Thanks @sdether I had a look around the use of connections as well & this looked like it'd come under this PR as it's taking that alias into account if...

@eeriksp This sounds like a great feature. You've got a fair point about dependencies - something like this would be best as an optional dependency, like how you can do...

@eeriksp Could you please install this beta build and verify everything is working as expected; https://pypi.org/project/django-sql-explorer/2.5b0/

I'm not aware of a timeout. But I don't think I've ever had a query run for that long.

Yeah that sounds like a good feature. Similar to #119 which suggests being able to mark a query as a favourite.

Nice, thanks. Let me know if you need any help or my opinion on anything 👍