Mark Stosberg

Results 505 comments of Mark Stosberg

Still waiting on the update for Dates.

Review the test suite and choose a good location.

I did my own bisect and got the same result. I also tried Node 8 and it failed on that test too. I also checked to see if maybe the...

👍🏼 Looks like this doesn't cause any new test failures.

I'm in favor of merging this, but would like to get #704 resolved first. You are welcome to take a look if you'd like.

This appears to conflict with your other PR. I'll merge it when the conflicts are resolved.

@hershmire The regression was not intentional. I've asked @fgheorghe who wrote the patch #516 to investigate. Ideally we'd like that fix without regressions, but maybe we can't have both and...

@NilSet It seems like each sub-module should have a private configuration. The best way to do this may be with breaking changes. It was addressed in this fork, which should...

This was implemented in the branch linked to from #569. That solution included shims so the old paths/names worked. Someone interested in implementing this could check out that code. The...