mini-asset icon indicating copy to clipboard operation
mini-asset copied to clipboard

Uglifyjs with sourcemaps option and file list.

Open genellern opened this issue 8 years ago • 5 comments

Uglifyjs doesn't create source maps from STDIN, so we need the list of files.

You could put the domain in the asset_compress.ini like --source-map-url http/yourdomain/cached_js/scripts.js.map. And the option to create it. create_map = true.

genellern avatar Jan 26 '17 10:01 genellern

Current coverage is 86.68% (diff: 0.00%)

Merging #38 into master will decrease coverage by 0.59%

@@             master        #38   diff @@
==========================================
  Files            35         35          
  Lines          1022       1029     +7   
  Methods         173        174     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            892        892          
- Misses          130        137     +7   
  Partials          0          0          

Powered by Codecov. Last update 18d2be3...83bae0f

codecov-io avatar Jan 26 '17 11:01 codecov-io

In the compress_asset.ini file:

[filter_Uglifyjs]
options = -c --source-map-include-sources --source-map-url http://domain/cached_js/scripts.js.map --source-map WEBROOT/cache_js/scripts.js.map

genellern avatar Jan 27 '17 02:01 genellern

Thanks, I can use that to update the documentation.

markstory avatar Jan 27 '17 19:01 markstory

@markstory Is there sth else to do? I really need this feature :)

cleptric avatar Feb 15 '17 00:02 cleptric

I tried with realpath() to get it to work with file names with spaces, but I get errors at the helper level, which is beyond the scope of this PR.

genellern avatar Feb 15 '17 00:02 genellern