lint-review icon indicating copy to clipboard operation
lint-review copied to clipboard

Published 20 hours ago • verified publisher icon markstory

Report linting of an entire project via the github status API

Open adrianmoisey opened this issue 10 years ago • 7 comments

It would be nice if the result of a linting of the entire project is reported to the github status api (https://github.com/blog/1227-commit-status-api). Then there should be an option to allow this call to fail if there are more then n linting issues

adrianmoisey avatar Oct 16 '15 12:10 adrianmoisey

Sounds pretty useful.

markstory avatar Oct 16 '15 18:10 markstory

The pygithub3 package is blocking this, as it doesn't support that endpoint yet.

adrianmoisey avatar Oct 19 '15 18:10 adrianmoisey

https://github.com/sigmavirus24/github3.py supports the statuses API. I'm going to take a crack at implementing this

minichate avatar Nov 29 '15 16:11 minichate

It's already been done, thanks though. See https://github.com/markstory/lint-review/pull/74 and https://github.com/markstory/lint-review/pull/77

adrianmoisey avatar Nov 29 '15 16:11 adrianmoisey

My plan for this issue was to use the status endpoint for a report of the entire project's linting. @markstory do you think that's a good one to add?

adrianmoisey avatar Nov 29 '15 16:11 adrianmoisey

@adrianmoisey How would that work? So much of lintreview is focused on pul requests right now?

markstory avatar Nov 30 '15 01:11 markstory

I'm not too sure really. Let me hack away and see if I can get it working, I imagine it won't be too hard. Then you can decide if it's useful.

adrianmoisey avatar Nov 30 '15 04:11 adrianmoisey