asset_compress icon indicating copy to clipboard operation
asset_compress copied to clipboard

AssetCompressHelper::url() does not add base name

Open saeideng opened this issue 5 years ago • 2 comments

home page : http://localhost/sub_folder

$this->AssetCompress->url('css-combined.css');

What happened

returns

/assets/css/css-combined.v123.css

What you expected to happen

should be

/sub_folder/assets/css/css-combined.v123.css

version :

markstory/asset_compress 3.3.0

saeideng avatar Mar 08 '20 10:03 saeideng

if this is expected only add a note to top of method change that is not BC I just want to know this will not change for avoid duplicating with bellow code

        $path = $this->AssetCompress->url($css);
        $path = $this->Url->build($path);

saeideng avatar Mar 08 '20 10:03 saeideng

It has been a while since I looked at this code. I will see if base paths have ever been included in asset paths.

markstory avatar Mar 08 '20 20:03 markstory