Mark Turner

Results 246 comments of Mark Turner

I guess requirements might require somewhat similar changes to @Ecarrion's work on: #1215 #1218 #1223

Seem to recall executing something like this: ```shell /usr/bin/xcrun --sdk macosx swift package --allow-writing-to-package-directory sourcery-code-generation ```

Do we need to update the comment on the templates? ```swift Required Sourcery: 1.8.0 ```

Is this a dupe of https://github.com/MakeAWishFoundation/SwiftyMocky/pull/352 ?

@JustasL makes more sense to extend `Async`: ```swift extension Async { func delay(by timeInterval: TimeInterval) -> Async { return Async { callback in self.run { value in DispatchQueue.main.asyncAfter(deadline: .now() +...

@JustasL can you make amends to bring in these changes? https://github.com/markst/swift-snapshot-testing/commit/029c66aa6ad8cf226025576dbd0289cfea5e800d Also make it clear to mention that this delay needs to occur between presentation to window `prepareView` & `renderer`....

Noticed this yesterday, where by I was trying to make a long screenshot of my collection view which each had cell's loading remote images. Now I'd never use remote images...

I guess the delay needs to be between the `prepareView` & `renderer` closure: https://github.com/pointfreeco/swift-snapshot-testing/blob/main/Sources/SnapshotTesting/Common/View.swift#L966

Might be somewhat similar to #173