docker-magento icon indicating copy to clipboard operation
docker-magento copied to clipboard

Add healthcheck for all containers

Open rangerz opened this issue 4 years ago • 1 comments

According to the HEALTHCHECK for docker containers I mentioned in here

@markshust, please rebuild all of php (7.3, 7.4, 8.0) and elasticsearch(6.8, 7.6) images. Thanks :+1:

In bin/status also can view all health status

magento2.test git:(master) ✗ ./bin/status                                                        git:(master|●4✚2…5
            Name                          Command                  State                         Ports
------------------------------------------------------------------------------------------------------------------------
magento2test_app_1             /docker-entrypoint.sh ngin ...   Up (healthy)   80/tcp, 0.0.0.0:80->8000/tcp,
                                                                               0.0.0.0:443->8443/tcp
magento2test_db_1              /docker-entrypoint.sh --ma ...   Up (healthy)   0.0.0.0:3306->3306/tcp
magento2test_elasticsearch_1   /usr/local/bin/docker-entr ...   Up (healthy)   0.0.0.0:9200->9200/tcp,
                                                                               0.0.0.0:9300->9300/tcp
magento2test_mailhog_1         MailHog                          Up (healthy)   0.0.0.0:55038->1025/tcp,
                                                                               0.0.0.0:8025->8025/tcp
magento2test_phpfpm_1          docker-php-entrypoint php-fpm    Up (healthy)   9000/tcp, 9001/tcp
magento2test_rabbitmq_1        docker-entrypoint.sh rabbi ...   Up (healthy)   15671/tcp, 0.0.0.0:15672->15672/tcp,
                                                                               25672/tcp, 4369/tcp, 5671/tcp,
                                                                               0.0.0.0:5672->5672/tcp
magento2test_redis_1           docker-entrypoint.sh redis ...   Up (healthy)   6379/tcp

Refs: magento/magento-cloud-docker sun-asterisk-research/docker-php

rangerz avatar Feb 01 '21 09:02 rangerz

@rangerz this has been sitting here a long time. Should it be worked on & merged in? It's a bit invasive, I want to make sure we need this, as there seems to be many moving pieces to implement this. I've really never had a problem with my Docker containers being in an unhealthy state.

markshust avatar Oct 14 '21 17:10 markshust

@markshust

Forget the above message

I added docker-compose.healthcheck.yml for bin/start without until statement in bash script

Please review it.

rangerz avatar Oct 13 '22 04:10 rangerz

Hi @rangerz, all looks good! But I don't see any additions to bin/start. Did you want me to merge this for testing, or is this missing an update in bin/start?

I just merged your other big PR in for docker-compose/docker compose, so perhaps that needed to be merged in first?

markshust avatar Oct 20 '22 16:10 markshust

@markshust Yes, here is waiting for the bin/docker-compose commit.

It's updated to put docker-compose.healthcheck.yml into bin/docker-compose and then remove until wait for RabbitMQ and Elasticsearch services

rangerz avatar Oct 20 '22 21:10 rangerz

Awesome... this is sweet!!! 🧡🧡🧡

markshust avatar Oct 24 '22 16:10 markshust