docker-magento icon indicating copy to clipboard operation
docker-magento copied to clipboard

Minor fixes to compose.healthcheck.yaml and Makefile

Open mrifqyabdallah opened this issue 6 months ago • 1 comments

1. Increase the retries number on the compose.healthcheck.yaml file, from 3 to 30

Fixes #1346. See my comment inside.

2. Fixed typo and syntax error on the Makefile

After cloning the repo and running make on my CLI, I get the following error:

Screenshot 2025-06-19 135157

At line 42 of the Makefile file, turns out there's a missing parentheses.

I also escape all the backticks and change all comma signs with the $(comma) variable in order to remove the unexpected EOF warning.

mrifqyabdallah avatar Jun 19 '25 07:06 mrifqyabdallah

PR Summary

  • Version Update The product version has been upgraded from 52.0.1 to 52.0.2 for better performance and to include the latest fixes.

  • Fix for OpenSearch on Linux A new fix has been added to prevent OpenSearch from failing during startup operations on Linux systems.

  • Improvements on Command Descriptions Updates have been made to improve readability and clarity in command descriptions within the compose/Makefile. This includes adding code notations for better distinction and consistency in descriptions of various commands.

  • Increased Healthcheck Retries The retry count for healthchecks in the system has been increased from 3 to 6. This change was made to enhance system robustness, allowing it to withstand more consecutive failed health checks before being marked as unhealthy. It leads to improved fault tolerance in the system.

what-the-diff[bot] avatar Jun 19 '25 07:06 what-the-diff[bot]

Fixes https://github.com/markshust/docker-magento/issues/1346

markshust avatar Jul 01 '25 13:07 markshust

Thanks so much for the PR and extra fixes.

I did decrease the retry count from 30 though to 6. The default retry interval was 5s, which means that when it was set to 3, if a service did not start within 15 seconds it would fail. Setting this to 30 would mean that we would need to wait... 150 seconds! Which is nearly 3 minutes. So instead, I changed this to 6, which would increase the timeout from 15 seconds to 30 seconds.

Note that this was a global change made to all services, so we need to be mindful of the updates here. We actually do want the Docker startup to fail if things take too long to get up & running, so users aren't twiddling their thumbs for a few minutes when an issue is preventing the start. I'm guessing that 6 will work just fine, but if it doesn't, we will probably need another fix, or a setting that targets the opensearch service specifically.

I'm merging this in as a bugfix release in tag 52.0.2 and it'll be out momentarily.

markshust avatar Jul 01 '25 13:07 markshust