docker-magento icon indicating copy to clipboard operation
docker-magento copied to clipboard

Published 20 hours ago • verified publisher icon markshust

Update README.md

Open kmilodenisglez opened this issue 1 year ago • 5 comments

added some dependencies that were needed to be able to run magento-docker successfully on a VPS with Debian GNU/Linux 12

kmilodenisglez avatar Jan 26 '24 00:01 kmilodenisglez

PR Summary

  • Enhancement of Linux Installation Instructions The PR includes a valuable update that adds instructions to install the necessary dependencies specifically on Linux systems.

  • Revamped Docker Guide for Linux The directions for running Docker on Linux have been updated to include the necessity of certain post installation commands and the installation of Docker Compose, making it more comprehensive for Linux users.

  • Comparison with Docker Desktop It was noted in this PR that, unlike with Docker Desktop (which is a comprehensive desktop application), the Linux installation requires manual setup of these steps.

  • Magento Installation Guidance Lastly, the PR also adds a reminder for users to copy compose.dev-linux.yaml to compose.dev.yaml before installing Magento. This step is vital to ensure a successful installation of Magento.

what-the-diff[bot] avatar Jan 26 '24 00:01 what-the-diff[bot]

Updated the README.md with some dependencies that needed to be installed on a VPS with Debian GNU/Linux 12 installed.

Dependencies:

  • curl
  • libnss3-tools
  • unzip
  • rsync
  • bc

kmilodenisglez avatar Jan 26 '24 00:01 kmilodenisglez

Thanks for the PR. I think it would make sense to move this to the Linux section at https://github.com/markshust/docker-magento#linux instead?

Also, there is only one item here so I don't think there is a need for a 1. bullet point.

markshust avatar Feb 24 '24 17:02 markshust

Thanks for the PR. I think it would make sense to move this to the Linux section at https://github.com/markshust/docker-magento#linux instead?

Also, there is only one item here so I don't think there is a need for a 1. bullet point.

yes you're right

kmilodenisglez avatar Feb 28 '24 04:02 kmilodenisglez

@markshust I just modified the readme.md of this same PR, check it and tell me.

kmilodenisglez avatar Feb 28 '24 04:02 kmilodenisglez

@kmilodenisglez for some reason I cannot make changes to this PR myself, so can you make a couple more updates?

  1. Move the block that added to just before the #### The host.docker.internal hostname line. The lines that followed your previous line block are basic lines about running Docker on Linux, and should come first.
  2. Add a description after your heading to remain consistent with the rest of the documentation. It can say something like "docker-magento requires a few system dependencies to be installed on Linux in order to function properly. Please execute the following line from terminal to install these dependencies:"

markshust avatar Mar 06 '24 15:03 markshust

@kmilodenisglez for some reason I cannot make changes to this PR myself, so can you make a couple more updates?

  1. Move the block that added to just before the #### The host.docker.internal hostname line. The lines that followed your previous line block are basic lines about running Docker on Linux, and should come first.
  2. Add a description after your heading to remain consistent with the rest of the documentation. It can say something like "docker-magento requires a few system dependencies to be installed on Linux in order to function properly. Please execute the following line from terminal to install these dependencies:"

I already updated the readme

kmilodenisglez avatar Mar 07 '24 22:03 kmilodenisglez