Mark Shust
Mark Shust
+1 here also. Working with Magento (lots of files), impossible without something like this
Used dinghy for a new Magento 2 development process. Thought you'd like to know @codekitchen http://mageinferno.com/blog/magento-2-development-docker-os-x
Thanks for the issue report @Vindfrisk. Yes, I'll keep this issue open and will take any PR's that make this work. I would think this module should disable any functionality...
Just left a comment on the commit that just came in a few hours ago. Once I can test this and verify code is working, I can bring this in.
Hi @simonmaass -- this is my first day back from a little break. I'll be spending the next couple weeks on open source stuff, so will be testing this out...
Issue confirmed on 2.4.1. Testing out PR/commit.
Merged this PR, and also made some styling/coding updates on the other files to keep things consistent with the coding recommendations I made. Tagged as version 1.1.0.
Thanks for this report & info @royduin -- I'll re-open this ticket so we can fix this.
@sprankhub thanks for this! (and for reminding me... I've been quite absent-minded on GitHub lately). Merging in, will tag & release 👍
I'll gladly take in a PR which adds unit tests to correct this issue.