Mark Shannon

I'm still concerned about not counting the tlbc memory blocks in the refleaks test. Maybe you could count them separately, and still check that there aren't too many leaked, but...

I think there are two reasonable approaches to fixing this: 1. Strengthen the compiler/interpreter 2. Prohibit setting non-identifier keys in the underlying frame Given that setting an internal variable like...

I can segfault 3.12 and earlier with a variant of this. ```Py g = (x for x in range(10)) gen_expr_func = types.FunctionType(g.gi_code, {}) list(gen_expr_func(range(20))) print("No segfault") ``` The root cause...

So it looks like (1) is the correct fix. See https://github.com/python/cpython/pull/125178#issuecomment-2402332695 for a way to do this.

I don't understand the error: /home/runner/work/peps/peps/peps/pep-0805.rst:484: (WARNING/2) Inline emphasis start-string without end-string. Line 484 is in a block of C code.

Thanks @JelleZijlstra

Thanks for the comments and suggestions.

All these docs are now in main

Performance impact [without the JIT](https://github.com/faster-cpython/benchmarking/tree/main/results/bm-20241023-3.14.0a1%2B-2a3b1e2) is in the noise. Nominally 0.2% slower Performance impact [with the JIT](https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20241023-3.14.0a1+-031f320-JIT) is also in the noise. Nominally 0.2% faster. [Stats](https://github.com/faster-cpython/benchmarking/blob/main/results/bm-20241023-3.14.0a1%2B-2a3b1e2/bm-20241023-azure-x86_64-faster%252dcpython-load_const_return_re-3.14.0a1%2B-2a3b1e2-pystats-vs-base.md) shows that almost 90%...

The magic comment is "I have made the requested changes; please review again". I haven't, but I think I've justified my decisions. @iritkatriel