arduino-Max72xxPanel icon indicating copy to clipboard operation
arduino-Max72xxPanel copied to clipboard

Max72xxPanel is limited to a chain of 16 displays

Open Qrome opened this issue 7 years ago • 2 comments

Love the Panel driver and I am using it over on my https://github.com/Qrome/marquee-scroller Scrolling Weather Clock.

My software supports the chaining of several of the Matrix displays. We found that there is a limit with the current configuration of up to 16 displays because of the int8_t on line 106 of the Max72xxPanel.cpp file. When we changed it to be an int16_t then we were able to use 20 or more chained together.

Maybe you could consider updating line 106 to int16_t so that it isn't limited to just 16 displays. Thanks!

Qrome avatar Jul 27 '18 00:07 Qrome

Nice to hear this code is being reused. I don’t really actively support this library, but others mailed me this limitation too, and it seems an obvious change to perform. If you want you can send me a PR, otherwise I just fix this type myself.

Best, Mark

Op 27 jul. 2018, om 02:50 heeft Qrome [email protected] het volgende geschreven:

Love the Panel driver and I am using it over on my https://github.com/Qrome/marquee-scroller https://github.com/Qrome/marquee-scroller Scrolling Weather Clock.

My software supports the chaining of several of the Matrix displays. We found that there is a limit with the current configuration of up to 16 displays because of the int8_t on line 106 of the Max72xxPanel.cpp file. When we changed it to be an int16_t then we were able to use 20 or more chained together.

Maybe you could consider updating line 106 to int16_t so that it isn't limited to just 16 displays. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/markruys/arduino-Max72xxPanel/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkzSXW0tTmKpVFwaNRD8v__ePH5vv8bks5uKmPugaJpZM4ViwFT.

markruys avatar Jul 27 '18 05:07 markruys

Thanks Mark, I made a PR for you to look at. Thanks.

-David

Qrome avatar Jul 27 '18 13:07 Qrome