math-php icon indicating copy to clipboard operation
math-php copied to clipboard

Document additional Matrix Row Operations and add their Columnar counterparts

Open Aweptimum opened this issue 3 years ago • 5 comments

While working on #459, I noticed that there's a NumericMatrix->rowAddScalar() method that isn't documented and that there is no matching columnAddScalar. Should this be rectified? I couldn't find an issue referencing their implementation.

Edit: Noticed there's also rowSubtract and rowSubtractScalar

Aweptimum avatar Dec 30 '22 15:12 Aweptimum

Hi @Aweptimum,

Thank you for your interest in improving MathPHP.

When you say not documented, are you referring to the main README on the Github main project page, or in some PHPDoc comments in the code?

Thanks, Mark

markrogoyski avatar Dec 31 '22 02:12 markrogoyski

Just the main README. The doc blocks are perfectly fleshed out.

Aweptimum avatar Dec 31 '22 03:12 Aweptimum

Thanks. I've updated the README in the develop branch.

I think it makes sense to add corresponding column methods. If you would like to work on this let me know. Otherwise, I'll put it on my to-do list.

Thanks, Mark

markrogoyski avatar Dec 31 '22 04:12 markrogoyski

The README has been fixed in the latest version v2.7.0.

markrogoyski avatar Dec 31 '22 07:12 markrogoyski

Should be easy enough, I could probably do it Monday

Edit: I unfortunately do not have the time today :/

Aweptimum avatar Dec 31 '22 17:12 Aweptimum