Mark Rogoyski

Results 153 comments of Mark Rogoyski

Hi @JulienBohy, Thank you for sharing your code. Even if it is not a formal pull request, it is still helpful. We'll update this thread if there is any progress...

Are you thinking you'd want like `$rational->isEqual($arbitraryInteger)` to possibly be true while `$rational->isIdentical($arbitraryInteger)` would be false?

Casting to float is probably doing to have erratic results. For example: ```php php > echo 1/3; 0.33333333333333 php > var_dump(0.33333333333333 == 1/3); bool(false) ``` The ObjectArithmetic interface is really...

It looks like it is comparing properties, after having maybe transformed a scalar into an object. ```php public function equals($int): bool { $int = self::create($int); return $this->base256 == $int->toBinary() &&...

I think the Complex and ArbitraryInteger and maybe even the Polynomial if they have integers will work fine comparing to scalars, but the Rational is going to be the problem....

The ObjectVector makes sense with the pattern that is currently there and being developed. There are quite a few classes in the LinearAlgebra namespace, but that is not necessarily a...

```NumericMatrix``` sounds like a good name. Let's consider this for Version 2.0.0, as this would be a major API breakage of the current version.

I'd also rename ```MatrixFactory``` so the namespace fully describes it: ```Matrix\Factory::create([...])```

As @Beakerboy says, try out Vector outerProduct(). Also of interest may be Matrix kroneckerProduct(). Let us know if this works for you.

@TheFausap kroneckerProduct returns a matrix, which you can print as is: ```php $matrix = new Matrix([ [1,2], [3,4], ]); $kroneckerProduct = $matrix->kroneckerProduct($matrix); echo $kroneckerProduct; // [1, 2, 2, 4] //...