Reticulum icon indicating copy to clipboard operation
Reticulum copied to clipboard

change exit method in rncp

Open kujeger opened this issue 2 months ago • 2 comments

resolves issue #959, and aligns the exit method used with that in rnx.

I noticed that rnx uses exit(x) in all instances, whilst rncp always uses RNS.exit(x), but I've opted to only alter the instance after printing, as that was the only change needed to resolve this specific issue.

kujeger avatar Nov 03 '25 20:11 kujeger

That's probably a better way to do it. There's a whole lot of exit signalling circus going on for RNS to exit and clean up clearly on all platforms, and I'm hesitant to touch any of it Cause It Works Now™, but this is just in rncp and not the core RNS exit handler itself, so should be pretty easy to verify everything is OK. Just out of curiosity, how many platforms did you test this on?

markqvist avatar Nov 03 '25 21:11 markqvist

Cheers, I've only tested it on a couple of linux-es (fedora and alpine). I don't have any macos or windows machines to test on.

kujeger avatar Nov 04 '25 08:11 kujeger