markqvist
Fix --fw-version parameter not being used
Title basically.
Not sure why this if statement got removed? I assume it was accidental.
Regardless, without this change running something like:
rnodeconf -U --fw-version 1.71 --nocheck -u /dev/port
would fail, with the complaint that the firmware version was not set in the
command line arguments. Obviously this makes no sense and doesn't seem to be
intended.
~~There was some issues with using custom firmware versions at some point, and I think it got disabled there, or it was never properly finished. Can you confirm that it works correctly with custom versions now, for a repo that hosts older versions?~~
Ah, wait, was confused there for a second. This was also used for specifying offline install versions, when rnodeconf could not reach any online repositories, and you'd need to specify manually what version to use. It would then use that version from disk, if present.
I'll have to look at this in detail to see what is actually going on.
Sorry, I don't really understand what you mean in the bit you've crossed out.
Ah, wait, was confused there for a second. This was also used for specifying offline install versions, when rnodeconf could not reach any online repositories, and you'd need to specify manually what version to use. It would then use that version from disk, if present.
Yes, this is exactly what I was doing, I was using rnodeconf with a zip file (with a generated hash) manually copied from the RNode_Firmware in order to test flashing my own firmware with the autoinstaller. I had to disable the online repo option to do this. Basically, the change you made would stop it checking the firmware version before throwing the error that it wasn't set (and it couldn't reach the repo online). I hope that makes sense!