Mark Pollack

Results 465 comments of Mark Pollack

Apologies for my poor project management skills. Looks like we are good now. ``` public AzureOpenAiEmbeddingModel(OpenAIClient azureOpenAiClient, MetadataMode metadataMode, AzureOpenAiEmbeddingOptions options) { ```

Will need to add `@JsonInclude(Include.NON_NULL)` to all records/classes used in the low level APIs

I agree that the weather use case isn't going to confuse people in terms of the concept of temperature. Closing. Overall review of docs generally speaking is a generic task...

There is now support for [QianFan](https://docs.spring.io/spring-ai/reference/api/chat/qianfan-chat.html) does this meet your needs? @mxsl-gr What are your thoughts?

The other option that I think may solve this is to allow for swapping out the templating engine implementation. This way if one wants to use a templating engine that...

merged in 312156e2cbffb8d1e8ecfb0b4311004dc69a4a14 Thanks!

I'm not very familiar with Kotlin at this level. Is the fix you suggest to add `mapper.registerModule(JavaTimeModule())` the `JavaTimeModule` to the object mapper used in the `BeanOutputParser` ?

Hi. If possible to have in the same maven module that would be better. Sorry for the long delay.

I am not able to reproduce. Here is a working sample of your code. [myai.zip](https://github.com/spring-projects/spring-ai/files/14451620/myai.zip) Are you using any ChatOptions configuration in your code? That is an area in the...