marko icon indicating copy to clipboard operation
marko copied to clipboard

test(translator): check for shadowing `data` with a tag destructure

Open LuLaValva opened this issue 1 year ago • 2 comments

  • Maybe resolves #2254

Description

  • Added test for shadowing with a destructure
  • The shadowing issue mentioned in the issue is not replicated by Marko's test suite
  • With minimal testing, it seems this is not replicable. I will look further to attempt replication.

Checklist:

  • [x] I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • [x] I have updated/added documentation affected by my changes.
  • [x] I have added tests to cover my changes.

LuLaValva avatar Jul 09 '24 16:07 LuLaValva

⚠️ No Changeset found

Latest commit: d1f11d9ed49bbb1d43b1314de669959bc8f4dd82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 09 '24 16:07 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.24%. Comparing base (11d1389) to head (d1f11d9). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2257   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files         348      348           
  Lines       39449    39449           
  Branches     2561     2561           
=======================================
  Hits        34419    34419           
  Misses       5004     5004           
  Partials       26       26           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 09 '24 16:07 codecov[bot]

Although we're unable to reproduce I updated the branch to get this into the test suite anyway.

DylanPiercey avatar Dec 29 '24 21:12 DylanPiercey