marko
marko copied to clipboard
Dedupe enums
Description
This all might be bad but...
- Normalize enum naming/casing/pluralization
- Deduplicate enums shared between tags translator and runtime by moving them into the runtime. This also required moving the shared enums into the
/runtime-tags/common/types.ts
file (otherwise the tests would end up trying to run module scope code that relies ondocument
).
Checklist:
- [ ] I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
- [ ] I have updated/added documentation affected by my changes.
- [ ] I have added tests to cover my changes.
⚠️ No Changeset found
Latest commit: dcf77b24fd3a397eb41c896c385c632f0b6d1412
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Codecov Report
Attention: 20 lines
in your changes are missing coverage. Please review.
Comparison is base (
609fbbb
) 87.15% compared to head (dcf77b2
) 87.18%.
Additional details and impacted files
@@ Coverage Diff @@
## merge-x #2106 +/- ##
===========================================
+ Coverage 87.15% 87.18% +0.03%
===========================================
Files 325 325
Lines 31001 30965 -36
Branches 1449 1456 +7
===========================================
- Hits 27020 26998 -22
+ Misses 3972 3958 -14
Partials 9 9
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.