marko icon indicating copy to clipboard operation
marko copied to clipboard

Dedupe enums

Open rturnq opened this issue 1 year ago • 2 comments

Description

This all might be bad but...

  • Normalize enum naming/casing/pluralization
  • Deduplicate enums shared between tags translator and runtime by moving them into the runtime. This also required moving the shared enums into the /runtime-tags/common/types.ts file (otherwise the tests would end up trying to run module scope code that relies on document).

Checklist:

  • [ ] I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • [ ] I have updated/added documentation affected by my changes.
  • [ ] I have added tests to cover my changes.

rturnq avatar Feb 13 '24 00:02 rturnq

⚠️ No Changeset found

Latest commit: dcf77b24fd3a397eb41c896c385c632f0b6d1412

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 13 '24 00:02 changeset-bot[bot]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (609fbbb) 87.15% compared to head (dcf77b2) 87.18%.

Files Patch % Lines
...ckages/translator-interop/src/feature-detection.ts 58.82% 7 Missing :warning:
packages/translator-tags/src/util/tag-name-type.ts 80.00% 5 Missing :warning:
packages/runtime-tags/src/dom/signals.ts 83.33% 2 Missing :warning:
packages/runtime-tags/src/dom/walker.ts 88.23% 2 Missing :warning:
packages/translator-tags/src/util/walks.ts 95.74% 2 Missing :warning:
packages/runtime-tags/src/dom/fragment.ts 66.66% 1 Missing :warning:
.../translator-tags/src/visitors/tag/attribute-tag.ts 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           merge-x    #2106      +/-   ##
===========================================
+ Coverage    87.15%   87.18%   +0.03%     
===========================================
  Files          325      325              
  Lines        31001    30965      -36     
  Branches      1449     1456       +7     
===========================================
- Hits         27020    26998      -22     
+ Misses        3972     3958      -14     
  Partials         9        9              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 00:02 codecov[bot]