Bed_Distance_sensor icon indicating copy to clipboard operation
Bed_Distance_sensor copied to clipboard

Uninstall doesn't revert changes to `scripts/buildcommands.py`

Open dhoard opened this issue 1 year ago • 1 comments

When performing an uninstall, the change to scripts/buildcommands.pymade during installation...

sed 's/--dirty//g' "${HOME_DIR}/scripts/buildcommands.py" -i

... isn't reverted

dhoard avatar Apr 22 '24 18:04 dhoard

you can run this in the folder klipper to reset. git reset --hard

markniu avatar Apr 23 '24 06:04 markniu

@markniu I'm curious why you closed the issue without actually fixing it.

You provided a workaround, which is great, but the core issue still remains in the uninstall script.

dhoard avatar Apr 29 '24 10:04 dhoard

thanks, I just updated the uninstall.sh file for the buildcommands.py file recovery

markniu avatar Apr 30 '24 02:04 markniu