markmead
Feature - Added a new component under header
Description
This pull request adds a new navbar component with integrated search functionality, as discussed in issue #462.
Screenshots
Related Issue
Fixes #462
Checklist
- [x] Followed the contributing guidelines
- [x] Added the new component and ensured it works as expected
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| hyperui | ✅ Ready (Inspect) | Visit Preview | May 17, 2024 6:17pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this not just copied from another Tailwind CSS component library? There's stuff in there like data-state="closed" which makes no sense and even seen the word "Radix" in the code 🤦♀️
Not confident this is your own code and therefore I'm not looking to have this merged.
You've even left dark: classes in the light component which is lazy.
I apologize for the mistake. I was working on my portfolio where I used code from the ShadCN library for functional buttons on the navbar, and I mistakenly copied that code directly into this project. I understand that this is not acceptable, and I appreciate you pointing out the issues.
This is my first time contributing to an open-source project. To correct this, I will recreate the navbar component from scratch. I will make sure that all class names are consistent and relevant to the project.
Regarding the comment about the dark classes in the light component: I thought that different files for dark and light themes were for different renderings, and therefore I kept the code the same. I now realize that I should have followed the project's examples more closely.