slush-marklogic-node icon indicating copy to clipboard operation
slush-marklogic-node copied to clipboard

see more.. shown with < 5 values

Open grtjn opened this issue 10 years ago • 9 comments

if nr values smaller than facet limit, suppress see more..

grtjn avatar Sep 03 '15 14:09 grtjn

This should be on ml-search-ng, the functionality is totally contained there.

joemfb avatar Sep 03 '15 14:09 joemfb

Yes. Best to link to a ticket there, and keep this to update the bower dep..

grtjn avatar Sep 03 '15 17:09 grtjn

To be clear, you're asking that the stored search options be loaded initially, and the facet values be compared to their respective facet-limit property?

joemfb avatar Sep 03 '15 17:09 joemfb

Yeah, I guess that is how it needs to be done. Would be convenient if REST api would return a total facet count itself, but it doesn't. Although, we also have this includeAggregates that can provide a (total) count for a facet?

grtjn avatar Sep 03 '15 18:09 grtjn

I realize this should be moved over to ml-search-ng but would the behavior be too odd if show more only appeared on facets with 5 or more values? Unfortunately 5 would look sorta weird, but it'd eliminate the awkwardness of 2-4 valued facets

hunterwilliams avatar Sep 08 '15 11:09 hunterwilliams

Crossed my mind too, but reluctant on a solution like that..

grtjn avatar Sep 08 '15 12:09 grtjn

If we can't find a solution for this in 0.2.0, I suggest we disable the show more for the moment. It looks confusing like it is now, despite the fact that it is a really nice feature..

grtjn avatar Sep 16 '15 18:09 grtjn

I don't think show-more needs to be on by default. It's trivial to add to a demo if requested.

I think loading search-options when a new mlsearch context is initiated could be useful for lots of things, not just this, but I'd like to take time and get it right. I won't be free to work on it for awhile.

joemfb avatar Sep 16 '15 19:09 joemfb

Pushing this into next milestone..

grtjn avatar Sep 16 '15 20:09 grtjn