ML8 compatibility

[mblakele]

I think the following need attention for JSON changes:

• src/controller/fetch-training-calendar-events.xqy
• src/controller/get-updated-disqus-threads.xqy
• ~~src/controller/suggest.xqy~~ OK

[mblakele]

I don't know how to test the disqus or calendar endpoints, so I'm going to unassign myself for now.

[mblakele]

The admin-forms problem looks tricky.

• ML7
  • /Modules/MarkLogic/admin/admin-forms.xqy
  • /Admin/lib/admin-forms.xqy
• ML8
  • /Modules/MarkLogic/Admin/lib/admin-forms.xqy

With no path in common we can't write imports that will work for both. I think we have two options:

• Copy the code we need into toc.xqm. There's only one function, af:displayHelp, and it seems to be self-contained and relatively portable. However we might run into problems with v0.9 behavior, or there might be objections to copying admin code into an open-source project. There's also some risk that the format might change and we'd have to maintain the function.
• Use trickery with xdmp:function the output from xdmp:version. There doesn't seem to be any significant performance impact. This is closest to the old way, except for the trickier code.

@dsokolsky thoughts?

[dsokolsky]

If memory serves, all we need is that displayHelp function (and whatever else it needs). If that is the case, I think it is fine to just migrate that function to this repository. All it does is look in the schematic to grab some content and slightly transforms it (iirc....).

At any rate, the requirement for the app is to read that info from the schema. So I am fine with grabbing code from Admin and modifying as needed.

This is one of those things that we should make better some day and moving that code there is a good first step.