foxygestures icon indicating copy to clipboard operation
foxygestures copied to clipboard

Iframely iframes are not injected with content scripts

Open whjms opened this issue 7 years ago • 4 comments

  1. Place cursor over an iframe on page
  2. Hold gesture button
  3. Move mouse

Expected: gesture trail appears, gesture activates once button is released

Actual: gesture trail does not appear, gesture does not activate, browser's context menu appears once button is released

whjms avatar Sep 18 '17 00:09 whjms

I'm not sure if this is a (hopefully current?) limitation of WebExtensions, but it would be unfortunate if this can't be ported over from FireGestures.

whjms avatar Sep 18 '17 00:09 whjms

Gestures work fine on iframes and framesets. Can you provide a sample page where it fails?

marklieberman avatar Sep 18 '17 00:09 marklieberman

Hey, thank you for the quick response!

It looks like the issue appears only twitter frames provided by iframely (youtube and NYT seem to be working just fine). The first post on this page has an embedded tweet on it, and trying to start a gesture within the tweet area fails for some reason. See the circled area below:

image

whjms avatar Sep 18 '17 00:09 whjms

It appears to be caused by the strange manner in which iframely renders its iframe embeds. See this Stackoverflow post. https://stackoverflow.com/questions/18044073/iframe-without-src-but-still-has-content. The iframe never has a src with a URL, so Firefox never injects any content scripts. This is a potentially very difficult case to handle.

marklieberman avatar Sep 18 '17 02:09 marklieberman