gulp-ng-html2js icon indicating copy to clipboard operation
gulp-ng-html2js copied to clipboard

exported generateModuleDeclaration function

Open DmitryEfimenko opened this issue 8 years ago • 6 comments

This change allows to use function generateModuleDeclaration outside of pipe context. Mostly just code rearrangements so that function generateModuleDeclaration can both - be used by ngHtml2Js function and be exported. Also updated README to reflect new functionality. No breaking changes. The file comparison looks scary, but I just moved code around.

DmitryEfimenko avatar Mar 10 '16 08:03 DmitryEfimenko

hi, hope this could be merged some time soon. Also, just FYI, I didn't change anything in regards to the versioning. I'm not sure who's supposed to do that and when. Is it the maintainer's responsibility to do that when he's publishing a new version to npm?

DmitryEfimenko avatar Mar 11 '16 16:03 DmitryEfimenko

is anybody home?

DmitryEfimenko avatar Mar 20 '16 07:03 DmitryEfimenko

This would be useful for me as well, please merge in.

mattklein999 avatar Mar 24 '16 04:03 mattklein999

@DmitryEfimenko what is the use case for this? I think the proper fix for this would be to separate the actual functionality out into its own module, only leave the gulp specific things in this module and depend on that other module.

marklagendijk avatar Apr 01 '16 11:04 marklagendijk

I used it in a gulpfile here where I'm attaching converted html to the javascript file. You are right in that extracting this functionality in a separate module would work just fine, but to me it really does not matter much. If such extraction is made, gulp-ng-html2js would consist of 20 lines of code. I don't mind extra 20 lines of code loaded.

DmitryEfimenko avatar Apr 01 '16 17:04 DmitryEfimenko

will this be merged? I mean, there really are no breaking changes.

DmitryEfimenko avatar Jun 14 '16 19:06 DmitryEfimenko