Mark Molinaro

Results 14 comments of Mark Molinaro

I believe this is a bug in LoaderPlugin not calling `processModuleDependencies` when using `loaderContext.importModule` (used in MiniCssExtractPlugin). We can narrow it down to this location by noting this bug isnt...

Seems maybe this is solveable within webpack. To work around the issue, @pauldraper you can set `snapshot.module.hash = true`. to use hash of content instead of timestamp

Watchpack is properly watching `data/123.js` in addition to `main.js`. When we get the change event on `data/123.js`, we see the updated timestamp, and correctly emit `main.js` as the changed file...

Obviously not an efficient solution, but confirmed that fixing the timestamps correctly invalidates cache| ![image](https://user-images.githubusercontent.com/16494982/148140965-4dc4a816-5306-4b48-809c-54efbb448bcf.png) looking though watchpack, it seems we would need a little more in the way of...

> Seems maybe this is solveable within webpack. To work around the issue, @pauldraper you can set `snapshot.module.hash = true`. to use hash of content instead of timestamp This should...

This makes sense to me - I wonder if you have any perf traces or anything that could show any marked improvement from this change?

Actually - need to wait on this to figure out how to upgrade graceful-fs in webpack in a non-breaking way

Yes, all blockers are resolved - the only concern would be if folks are using an older 4.xx version of webpack which doesnt contain the change you linked, but only...

For at least initial/demonstration purposes, I think tacking on to swc-loader makes sense here (otherwise, we would have to make a bunch of changes to asyncify the parser parsing -...

Easy fix (and the one I will be using) is to just stop using BOM-encoded files :), but submitting the bug for posterity