JWTRefreshTokenBundle icon indicating copy to clipboard operation
JWTRefreshTokenBundle copied to clipboard

Deprecation warning: Implicitly marking parameter $authException as nullable is deprecated, the explicit nullable type must be used instead

Open BartekDe opened this issue 10 months ago • 18 comments

When using this package with PHP 8.4 a deprecation warning is emitted when the \Gesdinet\JWTRefreshTokenBundle\Security\Http\Authenticator\RefreshTokenAuthenticator::start function is called.

Gesdinet\JWTRefreshTokenBundle\Security\Http\Authenticator\RefreshTokenAuthenticator:: start(): Implicitly marking parameter $authException as nullable is deprecated, the explicit nullable type must be used instead in <b>.../vendor/gesdinet/jwt-refresh-token-bundle/Security/Http/Authenticator/RefreshTokenAuthenticator.php</b> on line <b>181</b><br />

BartekDe avatar Feb 01 '25 21:02 BartekDe

I see that there are 2 pull requests already opened that fix this issue.

@markitosgv do you plan to merge this soon? https://github.com/markitosgv/JWTRefreshTokenBundle/pull/389

BartekDe avatar Feb 01 '25 21:02 BartekDe

+1

ViPErCZ avatar Feb 04 '25 12:02 ViPErCZ

It has now been merged :) Waiting for a future release now

froozeify avatar Feb 11 '25 08:02 froozeify

Is it possible to have a tag with this fix?

XanderEVG avatar Mar 11 '25 07:03 XanderEVG

Is it possible to have a tag with this fix?

+1

s3bul avatar Mar 28 '25 06:03 s3bul

Is it possible to have a tag with this fix?

+1

Eskaaa avatar Apr 01 '25 08:04 Eskaaa

+1

samius avatar Apr 04 '25 08:04 samius

+1

stehled avatar Apr 04 '25 08:04 stehled

+1

mikusekdan avatar Apr 04 '25 08:04 mikusekdan

+1

DanHariton avatar Apr 04 '25 08:04 DanHariton

+1

TomasCzech avatar Apr 04 '25 08:04 TomasCzech

+1

domPatera avatar Apr 04 '25 10:04 domPatera

If it might be useful, I've created a patch to be used in the meantime, until a tag is published or a new release is created: https://gist.github.com/LucianoVandi/5fc0b9e6bfb5155e69ddcd019cbd4a3e

LucianoVandi avatar Apr 06 '25 07:04 LucianoVandi

@LucianoVandi Much appreciated! This should keep things going until the new version is out.

samius avatar Apr 07 '25 13:04 samius

+1

baquelo avatar Apr 15 '25 21:04 baquelo

+1

pawlus44 avatar Apr 30 '25 11:04 pawlus44

+1

Atantares avatar May 26 '25 09:05 Atantares

+1

ckonhaeuser avatar May 27 '25 16:05 ckonhaeuser

+1

Goazil avatar Jun 16 '25 07:06 Goazil

Release 1.5.0 should contain the changes and fix all. Reopen if still is a issue. Thanks!

shakaran avatar Jun 24 '25 15:06 shakaran