craftql icon indicating copy to clipboard operation
craftql copied to clipboard

Published 20 hours ago • verified publisher icon markhuot

Fixed `position` in image transformations

Open scottbaggett opened this issue 6 years ago • 2 comments

I noticed that the position value for the image transformation was not being respected. I made the updates to match the documented examples and now images are bring cropped correctly.

scottbaggett avatar Oct 29 '18 22:10 scottbaggett

Hrm, I thought only the keys were used in this enum. I left the values as human-readable text to be displayed in the GraphiQL UI. Let me test this out locally before getting it merged. Thanks!

markhuot avatar Oct 30 '18 00:10 markhuot

No worries. I wasn't sure so I dug around a bit and made the change locally and tested. I noticed pretty quickly that even with topLeft it was being cropped center center, so the position value wasn't being taken into account at all.

scottbaggett avatar Oct 30 '18 00:10 scottbaggett