mhvtl icon indicating copy to clipboard operation
mhvtl copied to clipboard

Wrong link to modprobe on Ubuntu

Open haniffm opened this issue 5 years ago • 12 comments

/usr/sbin/modprobe should be changed to /sbin/modprobe in https://github.com/markh794/mhvtl/blob/master/etc/mhvtl-load-modules.service.in#L14,L15

Otherwise the module wont be loaded.

haniffm avatar Apr 16 '19 07:04 haniffm

Agreed - I have this ready - along with a change to /lib vs /usr/lib install of systemd... I'll push these two into git now(ish). The thing was, I had it working on Unbutu yesterday - but it won't start for me today - still working on 'why' (oh, the joys of systemd ;) )

markh794 avatar Apr 16 '19 07:04 markh794

oh, tested the changes on CentOS, openSUSE & Ubuntu.

markh794 avatar Apr 16 '19 07:04 markh794

Which version of openSUSE did you test it with? I'm struggling with the openSUSE 15. It works on Centos7 and Ubuntu-xenial.

How do you test it? Do you have a script for building and starting it in a clean environment (Vagrant)?

haniffm avatar Apr 16 '19 14:04 haniffm

On Apr 16, 2019, at 7:53 AM, haniffm [email protected] wrote:

Which version of openSUSE did you test it with? I'm struggling with the openSUSE 15. It works on Centos7 and Ubuntu-xenial.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/markh794/mhvtl/issues/40#issuecomment-483696192, or mute the thread https://github.com/notifications/unsubscribe-auth/AByTHPWE7lp4e9B_5chRTmJQAn2jYf7-ks5vheQFgaJpZM4cxkg6.

I can help test on Leap 15.1, if you wish, as that’s what I run on my laptop.

— Lee Duncan

gonzoleeman avatar Apr 16 '19 16:04 gonzoleeman

@gonzoleeman I've created a PR (#41) which includes a Vagrant file and a script (which you should be able to run on your laptop as well).

haniffm avatar Apr 17 '19 07:04 haniffm

@haniffm I don't use Vagrant so I probably won't be able to get time to test that.

gonzoleeman avatar Apr 17 '19 22:04 gonzoleeman

For the record, I tested the latest as of today on my Tumbleweed system, and it compiled and installed (and ran) just fine.

Is there something in particular in Leap you need tested? Something about the modprobe?

gonzoleeman avatar Apr 17 '19 22:04 gonzoleeman

I feel I'm on the right trail to resolve this - I've found the 'systemd-path' command which returns the correct path to install mhvtl-device-conf-generator. Need to get into the office to re-install a fresh install of all three OS - to be sure I've not got anything left laying around from previous attempts.

markh794 avatar Apr 17 '19 22:04 markh794

It looks like getting the location of 64-bit libraries correct is a PITA if you want it to work for all distros.

gonzoleeman avatar Apr 22 '19 18:04 gonzoleeman

Need to get into the office to re-install a fresh install of all three OS - to be sure I've not got anything left laying around from previous attempts.

That is the reason I used Vagrant with a script to install everything automatically.

haniffm avatar Apr 22 '19 19:04 haniffm

Closing this one since it is now working on Ubuntu.

haniffm avatar May 03 '19 14:05 haniffm

Re-opening, since it is now broken again. Seems that this commit broke it: 642b553b0f8f40e65e96f473ff1f256d1f72a477

Looks like the mhvtl-device-conf-generator is in wrong directory: image

Its in /usr/lib/systemd/system-generators/ instead of being in /lib/systemd/system-generators.

haniffm avatar May 03 '19 14:05 haniffm