Mark Fields comments

Results 56 comments of


                                            Mark Fields

Test Infra: Always fail afterEach if expected errors don't match logged errors, even if the test isn't otherwise passing.

> I don't think this is really fully a testing issue, but an error reporting issue. I've had non-test users have similar issues where they spend a lot of effort...

Test Infra: Always fail afterEach if expected errors don't match logged errors, even if the test isn't otherwise passing.

Here's what the results look like in the console after this change: ![image](https://github.com/microsoft/FluidFramework/assets/12305068/0acae4d5-c02b-4e3c-9cb3-4ca129a87ac7) ![image](https://github.com/microsoft/FluidFramework/assets/12305068/7062866c-4241-4501-a6c1-db586c2bd235) Before the change, you see a strict subset of that (the "after each" stuff is missing,...

Test Infra: Always fail afterEach if expected errors don't match logged errors, even if the test isn't otherwise passing.

[Tests Tab](https://dev.azure.com/fluidframework/public/_build/results?buildId=278257&view=ms.vss-test-web.build-test-results-tab): ![image](https://github.com/microsoft/FluidFramework/assets/12305068/16b99f90-ce50-4e1e-ba4c-0c822aa83c04) And GitHub summary of failures: ![image](https://github.com/microsoft/FluidFramework/assets/12305068/327e701f-742c-471d-a814-06bf61842bb2) @anthony-murphy - I'll check Kusto too, was there any other UX you wanted to be tested? I didn't know what you...

Test Infra: Always fail afterEach if expected errors don't match logged errors, even if the test isn't otherwise passing.

I'll merge this after I'm back from leave

Remove IFluidHandleInternal.bind

Replaced by #24870

Remove `CompatibilityMode` case for "1" and `compatibilityModeRuntimeOptions["1"]`

@vladsud - On second thought, I don't think this has to happen at the 3.0.0 moment, what do you think? Here are the options it overrides: ```typescript "1": { //...