dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

CSS style color raising InvalidParameter when using plain generator

Open mcfadden opened this issue 3 years ago • 1 comments

When reaching out to the plain generator with a color option that uses the css style colors a Dragonfly::ParamValidators::InvalidParameter exception is raised.

Example - from within another generator:

  content.generate!(:plain, 100, 100, "format" => "png", "color" => "rgba(40,200,30,0.5)")

It looks like the color attribute is validated with is_word but that regex does not support css-style colors.

Other values that are failing, but should work:

  • #CCC
  • rgb(255,255,255)
  • #333

I have worked around it with a monkeypatch for now. I'm happy to open a PR if css style colors are still intended to be supported.

dragonfly version: 1.4.0

mcfadden avatar Jun 23 '22 19:06 mcfadden

Hi Thanks for this - this is indeed a bug - a PR would be great thanks - it should just be a case of colour and color being validated by a custom regex rather than is_word. Yes CSS colours should be supported (as far as imagemagick supports them anyway)

markevans avatar Jul 07 '22 12:07 markevans