dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

Documentation main page shows incorrect example

Open monomadic opened this issue 10 years ago • 1 comments

One of the very first examples on the documentation page http://markevans.github.io/dragonfly/ shows:

<%= image_tag @user.photo.thumb('300x200#')  # view  %>

Which is inconsistent with the imagemagick documentation for geometry, which seems to have moved those options into crop: http://www.imagemagick.org/script/command-line-processing.php#geometry

Should this be updated to reflect the current imagemagick documentation?

monomadic avatar Sep 13 '15 07:09 monomadic

actually that should have had ".url" on the end - fixed now!

I'm not sure about this to move to "^" I'd have to still support the old one (or deprecate in some way), but also '#' is slightly different in that you can have '#ne' (north-east), for example, which is a shorthand '^' doesn't have (as far as I know), so although it doesn't map directly to an imagemagick geometry, it's an addition, which I think is fine. What do you think?

markevans avatar Sep 15 '15 09:09 markevans