Mark Erikson

Results 1264 comments of Mark Erikson

Lenz tackled similar issues on the Apollo side here: - https://github.com/benjamn/optimism/pull/599 - https://github.com/benjamn/optimism/pull/615 - https://github.com/benjamn/wryware/pull/568 - https://github.com/apollographql/apollo-client/issues/11242

Lenz's latest example: ```ts import { weakMapMemoize, createSelectorCreator } from "reselect"; const memoize = createSelectorCreator(weakMapMemoize); const selector = memoize( (array: any[], from: number, to: number) => array, (array: any[], from:...

@paulgreg just to check, when you say "weakmaps were never released", do you mean "why didn't the weakmaps let go of the references they were holding on to"?

@hpierre74 any chance you could turn that into a small repro? Usage patterns are going to affect this and it would help to see how you're dispatching and reading the...

Honestly, the best answer here is to _not_ use `connect`, and instead use the React-Redux hooks API: https://react-redux.js.org/api/hooks

@uncaught the issue is that trying to _parse_ the stack and come up with the filename and such is more complex and browser-dependent. It's not impossible. But it would definitely...

We're open to PRs here, but the current system does show useful information as-is and this isn't an immediate priority for us.

@marksist300 unfortunately it's more complicated than just updating a couple of `render()` calls. The example repos need to be reworked, and that requires actually doing a bunch of Git history...

Usually! But in this case, it's a template/example repo. The _main_ purpose is to have a known sequence of commits that build the example app step-by-step, and the CodeSandboxes in...

I take that back, the "Fundamentals" tutorial repo still needs to be updated.