Mark Erikson

Results 1264 comments of Mark Erikson

@stchristian yeah, no one has looked at this in a year. Might be best to re-create it and file a new PR with the updates

Well, I ended up switching us to Vitest for our 2.0 branch. No one else has complained about this in _their_ tests, so I'm going to close this.

I don't see anything concrete for us to do here atm, and this issue appears to be stale. If folks do have specific changes they'd like us to consider making,...

@axinvd : yeah, that's to be expected. If an error is thrown in the reducer, then the state never actually gets updated.

Relevant thoughts over in the React Query repo: https://github.com/TanStack/query/discussions/4623 Also probably outdated discussion on Twitter: https://twitter.com/arnbzn/status/1435529763893006336

FWIW `normalizeRouterState` is part of Next's use of the Redux DevTools: - https://github.com/vercel/next.js/blob/ffdfd33251165d8b2f092568c8e4e5f08c71a636/packages/next/src/client/components/use-reducer-with-devtools.ts#L12 As far as I know, the Redux DevTools don't do anything to "mess with prototypes".