Mark Erikson

Results 1264 comments of Mark Erikson

Looking at this again briefly, it's going to be tricky to pull this off. I _think_ that if we could map over the already-sorted IDs to get the list of...

@G2Jose okay, I've got an initial PR up that seems to improve perf by about 50%. Could you try out the CI build as soon as it's done? https://github.com/reduxjs/redux-toolkit/pull/4361

@G2Jose @Jackman3005 I've updated the PR with several WIP variations. Currently it's using one that does some binary searches for insertions. Could you try that out and see how it...

I think I also found that some of the existing entity adapter logic relied heavily on reads into Immer-proxied state, and when done in bulk, that was slowing things down...

Per Ives ( https://twitter.com/CompuIves/status/1749223271340368263 ): > I think we're misdetecting that this should be a server environment. I can change our detection tomorrow morning to make it a client env!

That sounds plausible. @eric-crowell was doing some contributions prior to RTK 2.0 related to checking type exports for this sort of thing ( https://github.com/reduxjs/redux-toolkit/pulls?q=is%3Apr+author%3Aeric-crowell ), but it's possible more changes...

@aryaemami59 : maybe. As mentioned, I ran into issues attempting to bundle them while working on RTK 2.0. `tsup`'s bundler didn't correctly separate them out by entry point.

@nhayfield can you give a couple further details? - What do you mean by "normalize the endpoints"? - What's an example of "consolidating multiple calls"? - Where and how would...

@nhayfield can you show a concrete example of what a handwritten version of this looks like? I get the _general_ sense of what you're saying, but I need more details...

@nhayfield : I still don't think I understand _where_ in that query hook output you would expect to find and access the response headers. Something like `{data, isLoading, headers}` ?...