Mark Erikson

Results 1264 comments of Mark Erikson

I don't have a particular answer for this, tbh. We are still using Babel for the build output, just doing TS transpilation as part of that. I _did_ turn off...

For the record this has _nothing_ to do with Redux Toolkit, at all. If anything, it's something about how we updated our build steps in React-Redux as part of the...

@pjg that's part of the point of our recommendations at https://redux.js.org/usage/writing-tests#components . Your test code _will not care_ how the logic has been written. It will not matter whether it's...

FYI, @phryneas just did a bit of investigation, and it looks like the actual exports definitions may be fixable if we tweak our Babel settings: - https://github.com/babel/babel/issues/4265#issuecomment-770250799 - https://babeljs.io/docs/en/assumptions#constantreexports Doesn't...

@cafesanu This should have been fixed as of 8.0.2. Note that we still specifically advise _against_ doing this form of testing at all! But it should at least not crash.

@arcollector ~~it _should_ have been fixed. Can you post a project that shows this still happening?~~ waaaaaitaminute. I take that back. Did we not actually make this change? Maybe I...

Yeah. Sorry, I was wrong when I closed this. Lenz pointed out that the setting _could_ be changed. But no one has filed a PR to _actually_ change this setting.

Looking back at this again. It's still not a practice we want users to do, and it looks like there's a userland workaround at https://github.com/reduxjs/react-redux/issues/1920#issuecomment-1147559047 . Given that, I'm going...

The TS type declarations over in DT are pretty simple: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d459d36f4e1f47c3c6273b287718c79426e41a9f/types/react-redux/index.d.ts#L491 ```ts /** * Compares two arbitrary values for shallow equality. Object values are compared based on their keys, i.e....

And yeah, when I wrote the Hooks docs page in the first place, I was still relatively new to TS. So, I wrote some pseudo-ish type declarations. Close enough to...