Mark Erikson

Results 1264 comments of Mark Erikson

Yeah, that definitely can be reworded better :)

Yes, we do not currently ship our package in a fully Node-ESM compatible way. (Frankly this entire situation has been incredibly confusing for me every time I try to do...

@toychicken Yes, because ESM syntax has been pretty standard for writing client-side code for several years now. The Node situation is unfortunate, but not a reason to skip showing ESM...

As a follow-up: after some additional discussion, @karmaniverous and I concluded that what's actually going on is that Mocha in that template repo was configured to auto-register Babel, and a...

> fix the use of the thunkMiddleware which is a CommonJS package by the looks of it that sounds odd - we definitely ship an ESM file in the `redux-thunk`...

Right, I'm just saying that `redux-thunk` is not strictly a "CommonJS package". It does include multiple module formats in the published build artifact.

Dropping a key link in here about how to improve package publishing: https://github.com/frehner/modern-guide-to-packaging-js-library

Ironically I just ran into this yesterday while trying to deal with test failures from https://github.com/reduxjs/redux-toolkit/pull/2409 . I did indeed end up setting all of our `useFakeTimers` back to `'legacy'`:...

@kplatis Can you give an example of what you mean by "the more filters I have, the slower Redux becomes"? Ideally as a runnable CodeSandbox or a repo, with some...

@GriffinSauce : one option, if perhaps a bit unwieldy, would be to add a listener middleware entry that watches the relevant bits of state using the `predicate` option, and specifically...