Mark Erikson

Results 1264 comments of Mark Erikson

@dvargas92495 : what would a notional API change look like here?

@dvargas92495 we're always open to proposals and potential PRs, yeah.

@johannao76 : at the moment, there isn't one. At the moment this isn't on our roadmap, largely because _I_ don't have experience with anything like this and don't know what...

Yeah, that's the third option. I'd prefer _not_ to do that, to try to make it easier to keep the docs and code in sync, but it's a possibility.

Rebased this on top of the merged changes from #682

Hmm. Currently the logic is: ```ts function upsertManyMutably( newEntities: readonly T[] | Record, state: R ): void { const [added, updated] = splitAddedUpdatedEntities( newEntities, selectId, state ) updateManyMutably(updated, state) addManyMutably(added,...

Ah, good point. (Been a while since I've looked at this code :) ) Not immediately sure what a good solution is here without digging into it further.

@dlarroder there's been no comments since I wrote one a year ago, and the issue is still open, so no :)

At first glance, that sounds like normal Redux behavior. If you look at the Redux core inside of `dispatch()`, it does: ```ts try { isDispatching = true currentState = currentReducer(currentState,...

Can you record a Replay ( https://replay.io/record-bugs ) of the original issue, and share that here? That would make it a lot easier for me to see what's going on.