node-odbc icon indicating copy to clipboard operation
node-odbc copied to clipboard

[BUG] Memory leak from dependency @mapbox/node-pre-gyp

Open phpdave opened this issue 10 months ago • 1 comments

Describe your system

  • odbc Package Version: 2.4.9
  • Database Name: os400
  • Node.js Version: 20.18.2
  • Node.js OS: IBM i

Describe the bug npm install odbc warns of a memory leak

Image

Image

Expected behavior No memory leaks and use latest version based on this comment that 2.0.0 has fixed this https://github.com/mapbox/node-pre-gyp/issues/877#issuecomment-2526422933

To Reproduce

npm install odbc

phpdave avatar Feb 11 '25 21:02 phpdave

Thanks for bringing this to our attention again. Until 2.0 was published 17 days ago, there was nothing we could do about this. However, node-pre-gyp is only used during install time (to download pre-built binaries, if available), so memory leaks are unlikely to cause much problems.

Now that 2.0 is out, we can work on upgrading, however due to the major version bump to 2.0, it requires more care to evaluate. Potentially this is just because they bumped minimum Node requirement to 18.0? We'll have to do more testing to see what shakes out.

kadler avatar Feb 11 '25 23:02 kadler