git-semver icon indicating copy to clipboard operation
git-semver copied to clipboard

Doesn't handle double digits

Open emilgoldsmith opened this issue 6 years ago • 2 comments

Hi!

Thank you for this plugin it's a nifty little helper. Just wanted to point out that it doesn't handle several digits though. I've just been using it for building a new product right now and until deploying the first MVP we're just using v0.0.x and up to x=13 now, but since we reached x=10 it just gives fatal error v0.0.10 every time you call git semver patch, so we have to do it manually.

I'm assuming it's not too hard if you know bash well, I was trying to look at the code to see if I could do it myself but not a bash guru so it wasn't obvious to me anyway.

emilgoldsmith avatar Jun 20 '19 10:06 emilgoldsmith

Actually just took a quick look, seems it's the sorting that's the problem as the parsing seems okay. Maybe I'll put in a bit more time later and submit a fix, but got to go now

emilgoldsmith avatar Jun 20 '19 11:06 emilgoldsmith

I have pushed a PR (#46) that I believe fixes this (hope it will be merged soon), please let me know if you see further issues.

john-tipper avatar Nov 22 '19 12:11 john-tipper