mcp-go icon indicating copy to clipboard operation
mcp-go copied to clipboard

feat(mcptest): extend test server with prompt and resource support

Open vasayxtx opened this issue 5 months ago • 2 comments

Description

This PR enhances the mcptest.Server by adding comprehensive support for prompts and resources alongside the existing tools functionality.

Type of Change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] MCP spec compatibility implementation
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update
  • [x] Code refactoring (no functional changes)
  • [ ] Performance improvement
  • [ ] Tests only (no functional changes)
  • [ ] Other (please describe):

Checklist

  • [x] My code follows the code style of this project
  • [x] I have performed a self-review of my own code
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have updated the documentation accordingly

Summary by CodeRabbit

  • New Features

    • Added support for registering prompts and resources on the server, enabling interaction with custom prompts and access to resources.
  • Bug Fixes

    • Enhanced initialization logic for server capabilities related to resources and prompts to ensure thread-safe setup.
  • Tests

    • Added tests validating server behavior with prompts and resources, confirming accurate handling and responses.

vasayxtx avatar May 28 '25 09:05 vasayxtx

"""

Walkthrough

The changes introduce support for registering prompts and resources in both the MCP server and its test server. New methods and struct types are added to manage prompts and resources, including batch registration. Tests are updated and expanded to verify the new prompt and resource handling capabilities in the test server.

Changes

Files / Areas Change Summary
mcptest/mcptest.go Added prompt/resource slices to Server struct; added methods for adding prompts/resources; integrated into server startup.
mcptest/mcptest_test.go Renamed existing test; added new tests for prompt and resource registration and retrieval.
server/server.go Introduced ServerPrompt/ServerResource structs; added batch and single add methods; centralized capability registration with lazy init.

Possibly related PRs

  • mark3labs/mcp-go#149: Establishes the original mcptest package and Server struct, which this PR extends with prompt and resource support.
  • mark3labs/mcp-go#320: Adds a method for prompt deletion in MCPServer; both PRs modify prompt management within the server.

Suggested reviewers

  • ezynda3
  • robert-jackson-glean """

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de0304af04fd501af9644f7b8492cab1635e4f88 and d36a6f51e23c1929e3dc98784894592bd3b6763c.

📒 Files selected for processing (3)
  • mcptest/mcptest.go (3 hunks)
  • mcptest/mcptest_test.go (2 hunks)
  • server/server.go (7 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • mcptest/mcptest_test.go
  • mcptest/mcptest.go
  • server/server.go
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 28 '25 09:05 coderabbitai[bot]

@pottekkat coderabbit's comments are processed. Could you pls check the PR again? Thanks!

vasayxtx avatar May 29 '25 20:05 vasayxtx