Replace `http.Server` by a generic `ListenAndServer`

[inercia]

Replace http.Server by a generic ListenAndServer, so we do not enforce a specific implementation of the server.

Summary by CodeRabbit

• Refactor
  • Improved flexibility of server integration, allowing compatibility with a wider range of server implementations. No changes to user-facing behavior.

[coderabbitai[bot]]

Walkthrough

This change introduces a new interface, Server, which defines the methods ListenAndServe() error and Shutdown(ctx context.Context) error. The SSEServer struct is updated so that its srv field now uses this interface instead of being restricted to a concrete *http.Server type. Additionally, the WithHTTPServer function is modified to accept any implementation of the Server interface. The NewSSEServer constructor initializes srv as nil, deferring HTTP server creation until Start is called. No other logic or control flow in the codebase is altered.

Changes

File(s)	Change Summary
server/sse.go	Added the Server interface; changed SSEServer.srv field and WithHTTPServer function to use this interface instead of *http.Server; deferred HTTP server instantiation until Start.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 519b6b3626c381a0461bbb3d25e9ddf1b36a48db and fc34a1cd20db2820211cd28979fe474710cad8f6.

📒 Files selected for processing (1)

• server/sse.go (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• server/sse.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[penfree]

I think the SSEServer should have the two method handleMessage/handleSSE changed to public, so that they can easily be plugged into other frameworks like gin, so that we can use many existing middlewares and other Tracing/Logging/Metric tools。

So，the messes about using a native http.Server could be seperated from sse.go, maybe the current SSEServer should be SSEHandlers with another new SSEServer only do the work of http serving. Then users can implement their own GinSSEServer or something else.

[rwjblue-glean]

I think the SSEServer should have the two method handleMessage/handleSSE changed to public, so that they can easily be plugged into other frameworks like gin, so that we can use many existing middlewares and other Tracing/Logging/Metric tools。

This should be possible now. The underlying methods themselves weren't made public, but they are now exposed for you to use as http.Handler's as of https://github.com/mark3labs/mcp-go/pull/214.

[ezynda3]

Closing as the original use case of this is now possible.