mcp-go icon indicating copy to clipboard operation
mcp-go copied to clipboard

feat: Add Multi-Instance Support via Custom Channel Builders

Open rwjblue-glean opened this issue 7 months ago • 2 comments

Overview

This PR adds support for running multiple SSE server instances with shared state. It introduces a flexible, technology-agnostic approach using channel builders that allow for distributed message delivery across server instances.

Key Features

  • Custom Event Queue Builders: Allow customizing how server-sent events are distributed across instances
  • Custom Notification Channel Builders: Support distributed notification delivery
  • Redis Implementation: Provides a ready-to-use implementation using Redis pub/sub
  • No Core Dependencies: Maintains zero external dependencies in the core library
  • Comprehensive Tests: Includes tests using a mock broker to verify functionality

Technical Approach

Rather than tightly coupling the library to a specific technology (like Redis), this PR introduces builder functions that can create custom communication channels:

// Create a multi-instance SSE server using Redis
sseServer := server.NewSSEServer(
    mcpServer,
    server.WithBaseURL("https://api.example.com"),
    server.NewRedisEventQueueBuilder(redisClient),
    server.NewRedisNotificationChannelBuilder(redisClient),
)

This approach has several advantages:

  • Users can implement different message broker solutions (Redis, RabbitMQ, SQS, etc.)
  • The core library remains focused and dependency-free
  • Testing is simplified using mock implementations

Implementation Notes

  • Channel builders are executed once per SSE session
  • The Redis implementation uses pub/sub for real-time message delivery
  • Communication channels are bidirectional for both producing and consuming messages
  • Tests use a mock broker to verify multi-instance behavior without external dependencies

Example Usage

import (
    "github.com/go-redis/redis/v8"
    "github.com/mark3labs/mcp-go/server"
)

func createMultiInstanceServer() *server.SSEServer {
    // Connect to Redis
    redisClient := redis.NewClient(&redis.Options{
        Addr: "redis:6379",
    })
    
    // Create MCP server
    mcpServer := server.NewMCPServer(
        "my-app", 
        "1.0.0", 
        server.WithToolCapabilities(true),
    )
    
    // Create SSE server with Redis-backed channels
    return server.NewSSEServer(
        mcpServer,
        server.WithBaseURL("https://api.example.com"),
        server.NewRedisEventQueueBuilder(redisClient),
        server.NewRedisNotificationChannelBuilder(redisClient),
    )
}

This solution enables horizontally scaling SSE servers while maintaining session consistency across instances.

rwjblue-glean avatar Apr 21 '25 22:04 rwjblue-glean

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 21 '25 22:04 coderabbitai[bot]

currently working on tweaks to the tests

rwjblue-glean avatar Apr 21 '25 22:04 rwjblue-glean