mcp-go
mcp-go copied to clipboard
Feature/add kill to stdio client
fix https://github.com/mark3labs/mcp-go/issues/167
According to the mcp sepecification
Kill proces on windows should recursively kill all children process because there are no process group on windows. Kill process on linux/unix just send SIGTERM AND SIGKILL to the process.
Summary by CodeRabbit
- New Features
- Improved process termination: processes now have a timeout-based forced termination fallback during closure.
- Enhanced Windows process termination to recursively kill child processes.
- Bug Fixes
- Ensured child processes on Windows are terminated when closing.
- Tests
- Added tests verifying proper process closure and failure of requests after closure.
- Chores
- Updated dependencies to support enhanced process management and system utilities.
"""
Walkthrough
This update introduces platform-specific process termination logic for the killProcess function in the client/transport package, with separate implementations for Windows and non-Windows systems. The Stdio.Close method is modified to implement a timeout when waiting for a subprocess to exit, invoking killProcess if the process does not terminate within three seconds. The test suite for the Stdio transport is expanded to verify that processes are properly terminated and that requests fail after closure. Several new dependencies are added to go.mod to support process management across platforms.
Changes
| File(s) | Change Summary |
|---|---|
| client/transport/close_on_other.go, client/transport/close_on_windows.go | Added platform-specific killProcess functions for process termination using gopsutil and OS-specific logic. |
| client/transport/stdio.go | Modified Stdio.Close to implement a timeout and invoke killProcess if the subprocess does not exit in time. |
| client/transport/stdio_test.go | Added tests to verify process termination and error handling after closure. |
| go.mod | Added new indirect dependencies for system/process management and utilities. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Ensure StdioMCPClient.Close terminates the mcp server child process (#167) |
✅ | |
| Add tests to verify process termination and error on requests after close (#167) | ✅ | |
| """ |
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.