mcp-go
mcp-go copied to clipboard
fix(client): set custom HTTP headers for start and init calls
Summary by CodeRabbit
- New Features
- Improved HTTP request handling by enabling the use of custom headers, offering enhanced flexibility for configuring requests.
Walkthrough
The changes update the HTTP request logic in the client/sse.go file. Both the Start and Initialize methods in the SSEMCPClient struct now include loops that iterate over a headers map to set custom HTTP headers. There are no modifications to any exported or public entities.
Changes
| File | Change Summary |
|---|---|
| client/sse.go | Added loops in Start and Initialize methods to iterate over a headers map and set custom HTTP headers. |
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between a0e968a752722d87063eb36ea0d55938e752f6dd and 3670e87b8dca62bee6ad93a76d62ffd9713a0cae.
📒 Files selected for processing (1)
client/sse.go(2 hunks)
🔇 Additional comments (2)
client/sse.go (2)
92-95: LGTM! Good addition of custom headers to the Start method.This change properly implements setting custom HTTP headers for the SSE connection initialization request, making it consistent with the
sendRequestmethod which already had this functionality. The headers are set after the standard headers, allowing custom headers to override standard ones if needed.
394-397: LGTM! Good addition of custom headers to the Initialize method.The implementation correctly sets custom HTTP headers for the initialization notification request, following the same pattern used in both the
Startmethod andsendRequestmethod. This ensures consistent behavior across all HTTP requests made by the client.
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai planto trigger planning for file edits and PR creation.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
I urgently need this feature; can someone help handle it? Thank you.
I think this feature has already been fulfilled by #114
Thank you @leavez!