mcp-go
mcp-go copied to clipboard
sse client add transport option
Summary by CodeRabbit
- New Features
- Added support for customizing the HTTP transport layer used by the SSE client, allowing more control over network behavior.
- Tests
- Introduced new tests to verify the custom HTTP transport integration with the SSE client.
"""
Walkthrough
The change adds a new client option function WithHTTPTransport in both client/sse.go and client/transport/sse.go. This function accepts an http.RoundTripper and returns a ClientOption that sets the Transport field of the internal http.Client used by the SSE client to the provided transport. Additionally, a new test case was added in client/sse_test.go to verify the functionality of this option by using a custom HTTP transport implementation that counts requests. No other logic or control flow changes were made.
Changes
| File(s) | Change Summary |
|---|---|
| client/sse.go | Added WithHTTPTransport function to set a custom HTTP transport by assigning the provided http.RoundTripper to the client's internal HTTP client's Transport field. Added import of net/http. |
| client/transport/sse.go | Added WithHTTPTransport function to set the internal HTTP client's Transport to a provided http.RoundTripper. |
| client/sse_test.go | Added new test subcase "WithHTTPTransport" using a custom RoundTripper implementation that counts requests. Added assert package import. |
Suggested reviewers
- ezynda3 """
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9a0931367c324158cf458f9d3884074478be114f and af18b87cd49da39c4a5efd625aacae486da26206.
📒 Files selected for processing (3)
client/sse.go(1 hunks)client/sse_test.go(2 hunks)client/transport/sse.go(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- client/sse_test.go
- client/sse.go
- client/transport/sse.go
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
This feature is quite useful internally. Since it requires a custom transport to function properly, we'd really appreciate it if you could review this PR and let us know if any further changes are needed. @ezynda3
IMHO: might be better to give option to give users the flexibility to override the httpClient as in https://github.com/mark3labs/mcp-go/pull/109
Could you add a simple test just so its documented how this is used?
Could you add a simple test just so its documented how this is used?
@ezynda3 done